Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(featureDev): placeholder message #4952

Merged
merged 1 commit into from
May 7, 2024

Conversation

kumsmrit
Copy link
Contributor

@kumsmrit kumsmrit commented May 7, 2024

Problem

Updated placeholder message for feature dev in planning phase which was misleading previously due to "Briefly" in message.

Solution

Updated placeholder message for feature dev in planning phase to new UX message

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kumsmrit kumsmrit requested a review from a team as a code owner May 7, 2024 20:06
@@ -28,7 +28,7 @@ export class QuickActionGenerator {
? [
{
command: '/dev',
placeholder: 'Briefly describe a task or issue',
placeholder: 'Describe your task or issue in as much detail as possible',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocker: Should we store this text in a constant and refer to it from all 3 places we need?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any of the messages being shared for webview ui across, as all messages are explicitly mentioned within the generators.

@justinmk3 justinmk3 changed the title Updated placeholder message for feature dev in planning phase fix(featureDev): placeholder message May 7, 2024
@justinmk3 justinmk3 merged commit 2d22d9d into aws:master May 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants