fix(amazonq): chat may hang in ts/js files #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 7, 2024
packages/core/src/codewhispererChat/editor/context/file/importReader.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
May 7, 2024
packages/amazonq/.changes/next-release/Bug Fix-1a8a24b4-8845-4955-84a5-895eaed1194e.json
Outdated
Show resolved
Hide resolved
…955-84a5-895eaed1194e.json
justinmk3
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Q chat will hang when the current opened file is ts/js and the syntax of the ts/js file is broken. See https://github.com/aws/aws-toolkit-vscode/pull/4876/files
Solution
Temporarily disable FQN extraction in Ts/Js files.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.