Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feate(amazonq): only display open chat codelens if authenticated #4955

Merged
merged 4 commits into from
May 8, 2024

Conversation

hayemaxi
Copy link
Contributor

@hayemaxi hayemaxi commented May 7, 2024

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hayemaxi hayemaxi requested review from a team as code owners May 7, 2024 22:19
@justinmk3
Copy link
Contributor

Looks like a test needs an update

@hayemaxi hayemaxi requested a review from a team as a code owner May 8, 2024 18:34
* is invalid/valid, but the current state displays something else. To guarantee the true state,
* use async method getChatAuthState()
*/
public getChatAuthStateSync(conn = this.conn): FeatureAuthState {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good solution

Co-authored-by: Nikolas Komonen <118216176+nkomonen-amazon@users.noreply.github.com>
@hayemaxi hayemaxi merged commit 199d0fa into aws:master May 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants