Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: get Amazon Q debug mode running #4963

Merged
merged 1 commit into from
May 9, 2024

Conversation

nkomonen-amazon
Copy link
Contributor

Amazon Q is not fully working in web, but this gets the Debug setup working so we can start developing

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Amazon Q is not fully working in web, but this gets
the Debug setup working so we can start developing

Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
@nkomonen-amazon nkomonen-amazon requested a review from a team as a code owner May 8, 2024 23:01
@@ -0,0 +1,15 @@
/*!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off topic / not a blocker: should we rename this to main.ts/mainWeb.ts as in toolkit: https://github.com/aws/aws-toolkit-vscode/blob/d27031ea5f26ece189a0921616e4676edbc84027/packages/toolkit/src/main.ts

or vice versa?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I was thinking that we should go back to using extension. I'll look to update this

@nkomonen-amazon nkomonen-amazon merged commit 40d6ce3 into aws:master May 9, 2024
13 of 14 checks passed
@nkomonen-amazon nkomonen-amazon deleted the amazonqWebDebugConfig branch May 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants