fix: copyPackageJson script development mode #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: With the recent addition for the null extension fix in debug mode, we ran the hack during actual packaging of the AWS Toolkit extension. This hack caused the vsix to not work Solution: Only run the hack during development. We did this by adding a flag to the handlePackageJson script to do the hack if the '--development' flag is given. Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
justinmk3
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
With the recent addition for the null extension fix in debug mode, we ran the hack during actual packaging of the AWS Toolkit extension. This hack caused the vsix to not work
Solution:
Only run the hack during development. We did this by adding a flag to the handlePackageJson script to do the hack if the '--development' flag is given.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.