feat: add conversation id on error messages in amazonqFeatureDev #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 13, 2024
packages/core/src/amazonqFeatureDev/controllers/chat/messenger/messenger.ts
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
May 13, 2024
sannicm
force-pushed
the
sannicm/convidonerror
branch
from
6ed1cf0
to
091b50c
Compare
sarayev
approved these changes
May 16, 2024
| @@ -194,7 +194,7 @@ export class FeatureDevController { | |||
| // TODO add type | |||
| private async processUserChatMessage(message: any) { | |||
| if (message.message === undefined) { | |||
| this.messenger.sendErrorMessage('chatMessage should be set', message.tabID, 0, undefined) | |||
| this.messenger.sendErrorMessage('chatMessage should be set', message.tabID, 0, undefined, undefined) | |||
There was a problem hiding this comment.
non-blocker: I wonder if session can be obtained before this line and the conversationId would be incliuded in this error, too.
Something we can discuss offline, not a big deal atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Even with the conversation id in the info logs, it could be cumbersome for a customer to get it. From UX feedback it was proposed to add the conversation on the error messages to be more specific and direct, and make the sharing of the conversation Id to customer support more convenient.
Solution
if the session has a conversation id, error messages will show the id with an accompanying text.
How the message will look:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.