devEnv: Fix Dev Env timeout + logs #4980

nkomonen-amazon · 2024-05-13T14:57:37Z

Problem:

We only tried to start the activity heartbeat on extension startup. So if
that failed due to something like an invalid connection, the heartbeat mechanism
would not start

Solution:

Try and start the heartbeat mechanism when the CC connection changes as well.
But if it is already running then we just skip it.
Also added better logs to help debug this issue. The user should see codecatalyst: DevEnvActivity: heartbeat sent at ... in the logs, which indicates we called the Dev Env /activity api

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

packages/core/src/codecatalyst/devEnv.ts

nkomonen-amazon · 2024-05-13T22:32:36Z

packages/core/src/auth/ui/vue/show.ts

@@ -714,47 +712,6 @@ const Panel = VueWebview.compilePanel(AuthWebview)
 let activePanel: InstanceType<typeof Panel> | undefined
 let subscriptions: vscode.Disposable[] | undefined

-let showManageConnections: RegisteredCommand<any> | undefined


Moved this code to login/commands.ts due to circular dependency issues

nkomonen-amazon · 2024-05-14T20:58:30Z

@justinmk3 could you give this a final look when you have time

packages/core/src/codecatalyst/devEnv.ts

We want more logs to help determine if the dev env heartbeat is working as expected Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>

The command that shows the login vue was having circular dependency issues. This moves that logic in to its own file to fix this. Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>

Problem: We only tried to start the activity heartbeat on extension startup. So if that failed due to something like an invalid connection, the heartbeat mechanism would not start Solution: Try and start the heartbeat mechanism when the CC connection changes as well. But if it is already running then we just skip it. Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>

nkomonen-amazon requested a review from a team as a code owner May 13, 2024 14:57

justinmk3 reviewed May 13, 2024

View reviewed changes