Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Q Transform - Bugfixes #4993

Merged
merged 40 commits into from
May 16, 2024

Conversation

damntrecky
Copy link
Contributor

@damntrecky damntrecky commented May 14, 2024

Problem

After launching our HIL feature and prod testing we found some issues we would like to fix.

  • Chore - fix spelling error
  • Bugfix - uploadId overwriting jobId causing issues calling getTransformation
  • Bugfix - fix Human in the loop chat messages

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Nick Ardecky added 30 commits March 28, 2024 11:44
- add file handler
- rename root service folder
@damntrecky damntrecky changed the title Bugfix/post launch issues Amazon Q Transform - Bugfixes May 14, 2024
@damntrecky damntrecky marked this pull request as ready for review May 15, 2024 18:09
@damntrecky damntrecky requested review from a team as code owners May 15, 2024 18:09
transformationJobId: jobId,
})
if (response !== undefined) {
telemetry.codeTransform_logApiLatency.emit({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a separate metric from codeTransform_logApiError ?
Can't you just report codeTransform_logApiLatency with result failed and missing fields if it fails?

@damntrecky damntrecky enabled auto-merge (squash) May 16, 2024 14:39
@damntrecky damntrecky removed the request for review from justinmk3 May 16, 2024 14:39
@damntrecky damntrecky merged commit 99a92e4 into aws:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants