Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Q feature dev name #5004

Merged
merged 5 commits into from
May 16, 2024

Conversation

kumsmrit
Copy link
Contributor

Problem

QFeature Dev was renamed to Amazon Q Developer Agent for software development; so updated the feature name for chat messages and logs.

Solution

Updated the Q feature dev name for chat messages and logs.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kumsmrit kumsmrit requested a review from a team as a code owner May 16, 2024 08:51
session?.state.phase
)
if (err instanceof WorkspaceFolderNotFoundError) {
this.messenger.sendAnswer({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this change related?

Copy link
Contributor Author

@kumsmrit kumsmrit May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated based on UX feedback as the older message contained feature name which was required to be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the WorkspaceFolderNotFoundError actually possible here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is where WorkspaceFolderNotFoundError will be thrown for case when workspace is not open.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a valid remark then the one from justin, it feels like it is being combined two features into one. The rename and the handling of this new error. I approve anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed as we do not want to show feature name in case of this error message.

This reverts commit 9439145.
@@ -440,7 +441,7 @@ export class FeatureDevController {
if (!this.isAmazonQVisible) {
const open = 'Open chat'
const resp = await vscode.window.showInformationMessage(
'Your code suggestions from Amazon Q are ready to review',
'The Amazon Q Developer Agent for software development has generated code for you to review',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: this is quite verbose

Copy link
Contributor Author

@kumsmrit kumsmrit May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is suggested by AWS documentation team as Qfeature dev has been renamed to Amazon Q Developer Agent for software development

@hayemaxi hayemaxi enabled auto-merge (squash) May 16, 2024 20:17
@hayemaxi hayemaxi merged commit d5211b7 into aws:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants