codecatalyst: fix invalid SSO profile in Dev Env #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When a Dev Env is spun up, the AWS Toolkit extension automatically creates an SSO profile in the Dev Env using the the sso session metadata in the ~/.aws/config file. In the scenario the ~/.aws/config file contained the session for a non-builder id session the SSO profile created would be incorrect due to the startUrl and Region being reversed with eachother when the SSO profile was created. This led to an invalid SSO profile, so any attempts to reauthenticate would fail. Solution: correctly create the SSO profile. Signed-off-by: Nikolas Komonen <nkomonen@amazon.com>
hayemaxi
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a Dev Env is spun up, the AWS Toolkit extension automatically creates an SSO profile in the Dev Env using the the sso session metadata in the ~/.aws/config file.
In the scenario the ~/.aws/config file contained the session for a non-builder id session (IdC), the SSO profile created would be incorrect due to the startUrl and Region being reversed with eachother when the SSO profile was created.
This led to an invalid SSO profile, so any attempts to reauthenticate would fail.
Solution:
correctly create the SSO profile by swapping the args in the method call.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.