Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): avoid auto scan if no workspace found #5006

Merged
merged 1 commit into from
May 15, 2024

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented May 15, 2024

Problem

Auto scans are triggered even if no workspace is found, for example creating Untitled file but not saving it, causing "No workspace found" errors

Solution

  • Don't run a scan if getWorkspaceFolder(uri) is undefined
  • Refactor condition

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ctlai95 ctlai95 marked this pull request as ready for review May 15, 2024 21:49
@ctlai95 ctlai95 requested a review from a team as a code owner May 15, 2024 21:49
@laileni-aws laileni-aws merged commit 292fa96 into aws:master May 15, 2024
14 checks passed
@ctlai95 ctlai95 deleted the fix-no-workspace-found branch May 15, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants