Amazon Q Code Transform: Improve UploadZip logging #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tincheng
changed the title
JuliaABurch
reviewed
May 16, 2024
| const uploadFileByteSize = (await fs.promises.stat(fileName)).size | ||
| getLogger().info( | ||
| `Uploading zip at %s with checksum %s using uploadId: %s and size %s kB`, | ||
| fileName, |
There was a problem hiding this comment.
Nit: is this fileName a full (relative/absolute) path? This variable could be better named if so
JuliaABurch
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a minor change to help customer troubleshoot issues related to file upload.
Solution
Log temporary file path and file size to be uploaded within IDE log.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.