lint: update @typescript-eslint, fix warnings #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
commented
May 24, 2024
| @@ -37,7 +36,7 @@ export default ESLintUtils.RuleCreator.withoutDocs({ | |||
| meta: { | |||
| docs: { | |||
| description: 'disallow awaiting on vscode notifications if the response is unused', | |||
| recommended: 'error', | |||
| recommended: 'recommended', | |||
There was a problem hiding this comment.
'error' is not a valid value here, apparently
Problem:
After updating to @typescript-eslint/parser 7.x, importing '@typescript-eslint/types/dist/generated/ast-spec' fails:
lib/rules/no-await-on-vscode-msg.ts(15,34): error TS2307: Cannot find module '@typescript-eslint/types/dist/generated/ast-spec' or its corresponding type declarations.
lib/rules/no-await-on-vscode-msg.ts(40,13): error TS2322: Type '"error"' is not assignable to type 'RuleRecommendation | RuleRecommendationAcrossConfigs<never[]> | undefined'.
lib/rules/no-only-in-tests.ts(13,62): error TS2307: Cannot find module '@typescript-eslint/types/dist/generated/ast-spec' or its corresponding type declarations.
lib/rules/no-only-in-tests.ts(32,13): error TS2322: Type '"error"' is not assignable to type 'RuleRecommendation | RuleRecommendationAcrossConfigs<never[]> | undefined'.
lib/rules/no-only-in-tests.ts(60,25): error TS2322: Type '`${any}OnlyErrMsg`' is not assignable to type '"describeOnlyErrMsg" | "itOnlyErrMsg"'.
Solution:
Import from '@typescript-eslint/utils' instead.
justinmk3
commented
May 24, 2024
Comment on lines
28
to
29
| switch (message.eventType) { | ||
| case 'GENERATE_CLICKED': | ||
| case TelemetryType.GENERATE_CLICKED: |
There was a problem hiding this comment.
This is another small disadvantage of enums. If a type was used, the literal value could be used instead.
There was a problem hiding this comment.
Would it be better now to switch it from enum in to a type instead? It looks safe to do
justinmk3
force-pushed
the
lint
branch
2 times, most recently
from
cccad7c
to
c89208e
Compare
nkomonen-amazon
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5034
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.