Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Timeout from SAM Template #626

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Use Timeout from SAM Template #626

merged 3 commits into from
Jun 19, 2019

Conversation

awschristou
Copy link
Contributor

Description

Local run/debug of SAM Applications now honors the Timeout field in SAM Templates

Related Issue(s)

#510

Testing

  • Ran Tests
  • On Windows, ran node8 and python3.6 with a sleep timer, and then set the sam template Timeout value to a value lower than the sleep timer. Saw the invoke calls fail with a timeout message from the Lambda engine.

image

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awschristou awschristou added this to the Sprint 25 milestone Jun 19, 2019
@awschristou awschristou changed the title Use Timout from SAM Template Use Timeout from SAM Template Jun 19, 2019
@codecov-io
Copy link

codecov-io commented Jun 19, 2019

Codecov Report

Merging #626 into develop will increase coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #626      +/-   ##
===========================================
+ Coverage    55.04%   55.04%   +<.01%     
===========================================
  Files          118      118              
  Lines         4671     4676       +5     
  Branches       692      693       +1     
===========================================
+ Hits          2571     2574       +3     
- Misses        2100     2102       +2
Impacted Files Coverage Δ
src/shared/codelens/localLambdaRunner.ts 28.69% <0%> (-0.25%) ⬇️
src/shared/templates/sam/samTemplateGenerator.ts 97.29% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09347df...40b361b. Read the comment docs.

@awschristou awschristou merged commit 666d525 into develop Jun 19, 2019
@awschristou awschristou deleted the awschristou/sam-timeout branch June 19, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants