Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dataraces by #102 #103

Merged
merged 2 commits into from
Apr 4, 2019
Merged

fix dataraces by #102 #103

merged 2 commits into from
Apr 4, 2019

Conversation

t-yuki
Copy link
Contributor

@t-yuki t-yuki commented Apr 4, 2019

I've found some dataraces induced by #102 and fixed them.
See attachment files for details.
(How can we avoid such data race hell with httprace...?)

(EDIT) I also fixed a nil panic.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

race2.txt
race3.txt
race.txt

@chrisradek
Copy link
Contributor

@t-yuki
Thank you for your contribution! This looks like a good change. I'll follow-up with a PR to make sure we also run tests using the -race argument to hopefully catch some of these issues sooner.

@chrisradek chrisradek merged commit c2ae71e into aws:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants