bugfix: close inprogress connect subsegments #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luluzhao
approved these changes
Apr 3, 2019
t-yuki
added a commit
to t-yuki/aws-xray-sdk-go
that referenced
this pull request
Apr 4, 2019
t-yuki
added a commit
to t-yuki/aws-xray-sdk-go
that referenced
this pull request
Apr 4, 2019
Merged
t-yuki
added a commit
to t-yuki/aws-xray-sdk-go
that referenced
this pull request
Apr 4, 2019
t-yuki
added a commit
to t-yuki/aws-xray-sdk-go
that referenced
this pull request
Apr 16, 2019
luluzhao
pushed a commit
that referenced
this pull request
Apr 30, 2019
t-yuki
added a commit
to t-yuki/aws-xray-sdk-go
that referenced
this pull request
May 9, 2019
luluzhao
pushed a commit
that referenced
this pull request
May 9, 2019
* fix nilp error by #102 for tls conn * extend recv time for GOMAXPROCS=1 env
logan
pushed a commit
to logan/aws-xray-sdk-go
that referenced
this pull request
Jul 2, 2019
* fixes race condition in centralized sampling test * connect subsegment closing more robust * add non-empty subsegment assertion to failing test * update aws_test for travis * adds additional tests
logan
pushed a commit
to logan/aws-xray-sdk-go
that referenced
this pull request
Jul 2, 2019
logan
pushed a commit
to logan/aws-xray-sdk-go
that referenced
this pull request
Jul 2, 2019
logan
pushed a commit
to logan/aws-xray-sdk-go
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#87
Description of changes:
The SDK sometimes generates a
connectsubsegment when tracing the AWS SDK, or using the traced HTTP client. In some cases, theconnectsubsegment is not closed, preventing its parent segment from being closed. This causes problems in Lambda, where we can't wait for the context passed to the facade segments to bedonebefore emitting.This change closes the
connectsubsegment when it is reasonable to assume that a connection was attempt has been completed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.