Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #115

Merged
merged 2 commits into from
Jun 1, 2019
Merged

Bugfix #115

merged 2 commits into from
Jun 1, 2019

Conversation

cep21
Copy link
Contributor

@cep21 cep21 commented Jun 1, 2019

Address two bugs that are causing travis to fail

Jack Lindamood added 2 commits May 31, 2019 17:12
The err is otherwise in the scope of the returned error
and a race with the spawned goroutine
None of the callbacks of ClientTrace can be assumed to not
call in goroutines with other callbacks.  We at least
need to lock each of these functions.  It is possible
we could investigate further and reduce some of these locks
once we clean up the segment locking order
@cep21
Copy link
Contributor Author

cep21 commented Jun 1, 2019

A more in depth explanation of each bug is attached to the git commit message of each (they didn't get sent to the PR text on github above)

@luluzhao luluzhao merged commit a1bf010 into aws:master Jun 1, 2019
@luluzhao
Copy link
Contributor

luluzhao commented Jun 1, 2019

@cep21 thanks for working on it. I merged it.

@cep21 cep21 deleted the bugfix branch June 11, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants