fix: remove json.Indent from segment debug logging #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sthulb, Thanks for the contribution. I have reviewed the PR. I might be able to merge this once we resolve the SQL test cases failure issue if that's okay. There's a data race going on with SQL tests which results in test failures sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#184
Description of changes:
Removes
json.Identfrom segment debug log. By usingjson.Identthe SDK will break logging tools that want to make use of this data. For example, this will break CloudWatch Logs Insights since it won't be able to inspect the JSON object.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.