Add proper TypeScript build logic #417
Conversation
Codecov Report
@@ Coverage Diff @@
## aws-v3-support #417 +/- ##
=================================================
Coverage ? 55.23%
=================================================
Files ? 37
Lines ? 2714
Branches ? 0
=================================================
Hits ? 1499
Misses ? 1215
Partials ? 0 Continue to review full report at Codecov.
|
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: [master] | |||
| pull_request: | |||
| branches: [master] | |||
| branches: [master, aws-v3-support] | |||
There was a problem hiding this comment.
@willarmiros Can you switch this PR to draft?
There was a problem hiding this comment.
Ah good call, sorry for the spam
|
@anuraaga this should now actually be ready for review if you wanna take a look :) |
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: [master] | |||
| pull_request: | |||
| branches: [master] | |||
| branches: [master, aws-v3-support] | |||
There was a problem hiding this comment.
| branches: [master, aws-v3-support] | |
| branches: [master] |
@anuraaga I wasn't sure whether or not I should. We have manually created export namespace middleware {
const IncomingRequestData: typeof import("./middleware/incoming_request_data");
}I'm sure we can make a series of changes to our source to make the generated declaration files work, but given that TS customers have been happy with the existing ones I'm not sure I'll prioritize it along with these changes. |
|
I'm going to keep CI enabled on the |
|
Oh ok if those are manual b declarations than sounds good didn't quite understand what's going on. |
* Revert "Revert PR #386 (#412)" This reverts commit 9e20d2e. * Add proper TypeScript build logic (#417) * build core files to dist directory * fixed unit tests * updated workflows and readme * try to fix windows * fix ls * slashes * no more ls * zstd decompress * see what bin has * removed rsync * fixes * added sh * try xargs instead * cleanups * fixed publishing logic * Redesign AWS SDK V3 instrumentation to use middleware (#416) * updated deps and type file * removed type keyword added deps * remove changes to js * updated versions * finished redesign of aws sdk v3 instrumentation * refactored buildAttributes signature * add compile back to workflow * bumped tsd version instead Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> * removed dependencies and added docs * add back most changes, update types * removed aws-v3 branch from CI * fixed codecov to use dist directory * added blog post link Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Issue #, if available:
#411
Description of changes:
These changes allow the repo to conform to TypeScript best practices of not committing transpiled code to source control as we were doing before. Now, we have a
compiletarget on the core package which should be run before testing or publishing the package. It transpiles the TypeScript in the source package, and copies the transpiled JavaScript and all other non-TS source files to adistdirectory, which will ultimately be tested or vended to customers.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.