Add support for Django 2.0 to 3.0 #206
Conversation
The previous location, django.core.urlresolvers, was deprecated in 1.10 and removed in 2.0
This middleware was redundant in Django 1.10 and removed in Django 2.0
Django sometimes uses SafeString instead of str for template names.
Jsonpickle serializes SafeString as `{ "py/newargs": ["django/forms/widgets/attrs.html"]}`
instead of `"django/forms/widgets/attrs.html" which is the reason for
the invalid subsegment name.
kmichel2
force-pushed
the
django-20-21-22-30
branch
from
0b5f759
to
3143be9
Compare
|
Hi, I fixed the issues I had when deploying xray with Django 3.0 but removed the commit in this PR enabling coverage with tox: I'm too confused about tox to create a correct configuration and only noticed #200 after pushing this code. |
|
Hi @kmichel-sereema |
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 84.21% 84.23% +0.01%
==========================================
Files 78 78
Lines 3067 3070 +3
==========================================
+ Hits 2583 2586 +3
Misses 484 484
Continue to review full report at Codecov.
|
This fixes a runtime issue with template names in subsegments (#168) and two failed imports during tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.