Issue #450: Chalice generate-pipeline can create incompatible yaml #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2017 23:35
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 93.71% 93.71% +<.01%
==========================================
Files 18 18
Lines 2880 2882 +2
Branches 377 377
==========================================
+ Hits 2699 2701 +2
Misses 131 131
Partials 50 50
Continue to review full report at Codecov.
|
|
Looks good, we just need to get a test added to this before we can merge. |
|
@jamesls , thanks for review. I will add a test . |
|
Thanks, looks good. I made some small changes to the test but otherwise looks good. Thanks for the pull request! |
|
Merged in 0be9ac8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If function name in
app.pycontains '_' or special characters, invalid cloudformation template is created. We need to remove the special characters before generating cloudformation template.