Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse addons template outputs to detect secrets #681

Closed
efekarakus opened this issue Feb 21, 2020 · 0 comments · Fixed by #684
Closed

Parse addons template outputs to detect secrets #681

efekarakus opened this issue Feb 21, 2020 · 0 comments · Fixed by #684
Assignees
Labels
area/addon Issues about addons.

Comments

@efekarakus
Copy link
Contributor

Task

We want to parse the Outputs section of the addons template generated in #646 to detect if an output value refers to a secret.

Programming model

See this gist for an example on how to do this with awslabs/goformation: https://gist.github.com/efekarakus/14814a0043905e5242626922b01ea859

package addons

type Outputs structs {
     ManagedPolicyARN string
     EnvVars []string
     Secrets []string
}

func (a *Addons) Outputs(template string) (*Outputs, error)

The Outputs object can then be passed into the web app template to inject secrets, env variables, and the managed policy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon Issues about addons.
Projects
Sprint 🏃‍♀️
  
Pending release
Development

Successfully merging a pull request may close this issue.

1 participant