Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass addon outputs to the application stack #698

Closed
efekarakus opened this issue Feb 27, 2020 · 0 comments · Fixed by #719
Closed

Pass addon outputs to the application stack #698

efekarakus opened this issue Feb 27, 2020 · 0 comments · Fixed by #719
Assignees
@efekarakus
Labels
area/manifest Issues about infrastructure-as-code templates.
Projects
Sprint 🏃‍♀️

Comments

@efekarakus
Copy link
Contributor

Ask

With #681 we can now detect if an addons template's outputs are referring to an IAM ManagedPolicy or SecretManager Secret.

We need to pass these outputs back to the application stack, so that they can be used as:

  1. If the output is not a secret or a managed policy => env var.
  2. If the output is a secret => use as a secret under the application container's definition.
  3. If the output is a managedpolicy => attach as a managed policy to the task role.
@efekarakus efekarakus added the area/manifest Issues about infrastructure-as-code templates. label Feb 27, 2020
@efekarakus efekarakus self-assigned this Feb 27, 2020
@efekarakus efekarakus added this to Backlog in Sprint 🏃‍♀️ via automation Feb 27, 2020
@efekarakus efekarakus moved this from Backlog to In progress in Sprint 🏃‍♀️ Feb 27, 2020
@efekarakus efekarakus mentioned this issue Feb 27, 2020
Closed
8 tasks
@efekarakus efekarakus mentioned this issue Mar 6, 2020
Merged
@efekarakus efekarakus moved this from In progress to In review in Sprint 🏃‍♀️ Mar 9, 2020
Sprint 🏃‍♀️ automation moved this from In review to Pending release Mar 11, 2020
efekarakus added a commit that referenced this issue Mar 11, 2020
@efekarakus
feat: pass addon outputs to the application stack (#719)
a44d176 
* feat: pass addon outputs to the application stack

Resolves #698

* refactor: move addons parsing logic from workspace to addons pkg

* refactor: rename fmtEnvVar to toSnakeCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efekarakus efekarakus

Labels
area/manifest Issues about infrastructure-as-code templates.
Projects
Sprint 🏃‍♀️
  
Pending release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass addon outputs to the application stack
1 participant
@efekarakus