fix(cli): add stricter validation to svc names #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
approved these changes
Mar 4, 2021
internal/pkg/cli/validate.go
Outdated
Comment on lines
59
to
64
| // s3 validation expressions. | ||
| // s3RegExp matches alphanumeric, .- from 3 to 63 characters long. | ||
| // s3DashesRegExp matches consecutive dashes or periods | ||
| // s3TrailingDashRegExp matches a trailing dash | ||
| // punctuationRegExp matches consecutive dashes or periods | ||
| // trailingPunctRegExp matches a trailing dash | ||
| // ipAddressRegExp checks for a bucket in the format of an IP address. | ||
| // https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-s3-bucket-naming-requirements.html |
There was a problem hiding this comment.
Seems like we have duplicated comments for explaining the same thing. Can we remove one of them?
There was a problem hiding this comment.
They look like they handle different things-- one is -- and the other is someName-, right?
There was a problem hiding this comment.
Yes, that's exactly right
|
Looks good, and yes-- speedy turnaround! |
|
@huanjani Yes; fixed in the latest push. |
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> As discussed in aws#2005, providing consecutive or trailing hyphens in the service or job name causes the ECR repository to fail to deploy. This is due to undocumented validation behavior in ECR, where trailing or consecutive punctuation characters are invalid names. Invalid service and job names will now fail at validation, not during a StackSet update, avoiding a problem where the StackSet became unmanageable by Copilot. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2005, providing consecutive or trailing hyphens in the service or job name causes the ECR repository to fail to deploy. This is due to undocumented validation behavior in ECR, where trailing or consecutive punctuation characters are invalid names.
Invalid service and job names will now fail at validation, not during a StackSet update, avoiding a problem where the StackSet became unmanageable by Copilot.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.