feat: enable job logs command #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d custom prefixes
use pagination for log stream fetching. rename variables. make sure log stream truncation and filtering are engaged in tests.
feat: enable command test: add job logs ask and validate tests; rename svcAppNameHelpPrompt chore: add execute tests
- chore: add job logs logic and validation - chore: update cloudwatchlogs to allow limiting log streams fetched and custom prefixes - chore: rename service.go to workload.go in logging pkg - chore: add logic for fetching state machine logs to workload - chore: add unit tests for workload logging pkg Adds unit tests and changes for the cloudwatchlogs and logging libraries necessary for job logs, specifically for getting one or N executions at a time, optionally including state machine logs. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
efekarakus
added
do-not-merge
Lou1415926
reviewed
Jul 22, 2022
It's made moot later, see this comment: https://github.com/aws/copilot-cli/pull/3794/files#r933412494
Lou1415926
approved these changes
Aug 11, 2022
Comment on lines
173
to
174
| require.Equal(t, param.LogStreamPrefixFilters, []string{"copilot/", "states"}) | ||
| require.Equal(t, param.Limit, aws.Int64(10)) | ||
| require.Equal(t, param.LogStreamLimit, 2) |
There was a problem hiding this comment.
are we still interested in what's passed in param.Limit? If so, what do you think of
require.Equal(t, param.LogStreamPrefixFilters, []string{"copilot/", "states"})
require.Equal(t, param,Limit aws.Int(10))
require.Equal(t, param.LogStreamLimit, 2)There was a problem hiding this comment.
Good idea; i've added a check here and a new test to ensure that some log stream limit behavior is working properly.
iamhopaul123
added
the
do-not-merge
iamhopaul123
approved these changes
Aug 11, 2022
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
… logStreamLimit work together
Lou1415926
added
do-not-merge
Lou1415926
approved these changes
Aug 11, 2022
bvtujo
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds job logs command and fixes a bug which randomized the sort order of log streams.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.