chore(pipelines): remove here string from buildspec #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
approved these changes
Oct 21, 2022
Codecov Report
@@ Coverage Diff @@
## mainline #4102 +/- ##
============================================
- Coverage 69.17% 69.14% -0.03%
============================================
Files 248 249 +1
Lines 35608 35656 +48
Branches 264 264
============================================
+ Hits 24631 24654 +23
- Misses 9782 9805 +23
- Partials 1195 1197 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
efekarakus
reviewed
Oct 21, 2022
| @@ -49,7 +49,7 @@ phases: | |||
| # Check if the `svc package` commanded exited with a non-zero status. If so, echo error msg and exit. | |||
| - > | |||
| for env in $pl_envs; do | |||
| tag=$(sed 's/:/-/g' <<<"${CODEBUILD_BUILD_ID##*:}-${env}" | rev | cut -c 1-128 | rev) | |||
| tag=$(echo ${CODEBUILD_BUILD_ID##*:}-$env | sed 's/:/-/g' | rev | cut -c 1-128 | rev) | |||
There was a problem hiding this comment.
Just to make sure was this tested in manually? do the tags in ECR look the same as before by default?
efekarakus
approved these changes
Oct 21, 2022
KollaAdithya
pushed a commit
to KollaAdithya/copilot-cli
that referenced
this pull request
Oct 21, 2022
Fixes second issue in aws#3553. Here strings (`<<<`) don't work with `sh`. This change makes the pipeline buildspec a bit more universal. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes second issue in #3553.
Here strings (
<<<) don't work withsh. This change makes the pipeline buildspec a bit more universal.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.