Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(templates): add scaffold files for CDK overrides/ #4291

Merged
merged 8 commits into from Dec 21, 2022

Conversation

efekarakus
Copy link
Contributor

@efekarakus efekarakus commented Dec 19, 2022

Related #4208

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@efekarakus efekarakus requested a review from a team as a code owner December 19, 2022 22:26
@efekarakus efekarakus requested review from KollaAdithya and removed request for a team December 19, 2022 22:26
@github-actions
Copy link

github-actions bot commented Dec 19, 2022

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 48300 47904 +0.83
macOS (arm) 48964 48576 +0.80
linux (amd) 42480 42124 +0.85
linux (arm) 41860 41472 +0.94
windows (amd) 39244 38940 +0.78

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #4291 (1fa5d1a) into mainline (8aebf75) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           mainline    #4291      +/-   ##
============================================
+ Coverage     70.00%   70.05%   +0.05%     
============================================
  Files           260      259       -1     
  Lines         36486    36643     +157     
  Branches        264      264              
============================================
+ Hits          25541    25672     +131     
- Misses         9726     9745      +19     
- Partials       1219     1226       +7     
Impacted Files Coverage Δ
internal/pkg/aws/route53/errors.go 85.71% <0.00%> (-14.29%) ⬇️
internal/pkg/cli/deploy/env.go 74.25% <0.00%> (-0.94%) ⬇️
...ternal/pkg/deploy/cloudformation/cloudformation.go 72.47% <0.00%> (-0.55%) ⬇️
internal/pkg/cli/env_deploy.go 54.27% <0.00%> (-0.05%) ⬇️
internal/pkg/cli/init.go 20.66% <0.00%> (ø)
internal/pkg/aws/route53/domain.go
internal/pkg/cli/app_init.go 67.01% <0.00%> (+2.85%) ⬆️
internal/pkg/aws/route53/route53.go 85.08% <0.00%> (+3.50%) ⬆️
internal/pkg/cli/env_package.go 46.08% <0.00%> (+4.28%) ⬆️
internal/pkg/template/artifactpath/artifactpath.go 35.29% <0.00%> (+21.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

efekarakus and others added 4 commits December 20, 2022 11:10
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@paragbhingre paragbhingre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, otherwise looks good to me. Feel free to remove the label.

@paragbhingre paragbhingre added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Dec 20, 2022
@kohidave
Copy link
Contributor

Very excellent.

@efekarakus efekarakus removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Dec 21, 2022
@mergify mergify bot merged commit 0b9299c into aws:mainline Dec 21, 2022
Sprint 🏃‍♀️ automation moved this from In review to Pending release Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Development

Successfully merging this pull request may close these issues.

None yet

5 participants