chore(sessions): add UserAgentExtras method to Provider #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍕 Here are the new binary sizes!
|
iamhopaul123
approved these changes
Jan 10, 2023
| @@ -70,6 +70,14 @@ func UserAgentExtras(extras ...string) func(*Provider) { | |||
| } | |||
| } | |||
|
|
|||
| // UserAgentExtras adds additional User-Agent extras to cached sessions and any new sessions. | |||
| func (p *Provider) UserAgentExtras(extras ...string) { | |||
There was a problem hiding this comment.
What extra things happens here in addition to existing UserAgentExtras function? Can't we use existing UserAgentExtras function for adding overrides cdk or overrides cfnpatch agents?
There was a problem hiding this comment.
The UserAgentExtras function can only be used in the constructor, the method is so that you can add any extras at any point.
So we can start with a provider that's like this for a command:
provider := sessions.NewProvider(sessions.UserAgentExtras("svc package"))
....
if override.IsCDK() {
provider.UserAgentExtras("cdk override")
}
paragbhingre
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a way to write a unit test that ensures the user-agent will have the extras on new requests.
However, I tested the method manually in
copilot app showand I can see the new extras added on requests.Related #4208
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.