chore(override): enable passing down COPILOT env vars to CDK files #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍕 Here are the new binary sizes!
|
iamhopaul123
approved these changes
Jan 11, 2023
Comment on lines
8
to
13
| readonly appName?: string; | ||
| readonly envName?: string; | ||
| } | ||
|
|
||
| export class TransformedStack extends cdk.Stack { | ||
| constructor (scope: cdk.App, id: string, props?: cdk.StackProps) { | ||
| constructor (scope: cdk.App, id: string, props: TransformedStackProps) { |
There was a problem hiding this comment.
if appName and envName are optional, why do we make props required?
There was a problem hiding this comment.
good question 😂 changed to appName and envName being required
Comment on lines
+25
to
+27
| exec struct { | ||
| LookPath func(file string) (string, error) | ||
| Command func(name string, args ...string) *exec.Cmd |
There was a problem hiding this comment.
Will this be a problem for mock for unit test?
There was a problem hiding this comment.
Nope! In the unit tests we use the public constructor to define our own custom behavior:
WithCDK("some/path", CDKOpts{
LookPathFn: func(string) (string, error) { return "", errors.New("some error") }
})
Codecov Report
@@ Coverage Diff @@
## mainline #4350 +/- ##
=========================================
Coverage 70.02% 70.03%
=========================================
Files 260 260
Lines 37030 37096 +66
Branches 266 266
=========================================
+ Hits 25931 25979 +48
- Misses 9853 9869 +16
- Partials 1246 1248 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4208
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.