Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): init should set appVersionGetter with correct app name #5126

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

iamhopaul123
Copy link
Contributor

Right now init interactive wizard is broken because we don't set appVersionGetter with correct app name. This PR fixes this issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner July 25, 2023 18:10
@iamhopaul123 iamhopaul123 requested review from Lou1415926 and removed request for a team July 25, 2023 18:10
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51484 51400 +0.16
macOS (arm) 51680 51604 +0.15
linux (amd) 45316 45244 +0.16
linux (arm) 43588 43524 +0.15
windows (amd) 42136 42072 +0.15

Copy link
Contributor

@dannyrandall dannyrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a question

internal/pkg/cli/init.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #5126 (35ff57e) into mainline (5109d75) will increase coverage by 0.01%.
Report is 1 commits behind head on mainline.
The diff coverage is 11.76%.

@@             Coverage Diff              @@
##           mainline    #5126      +/-   ##
============================================
+ Coverage     69.65%   69.67%   +0.01%     
============================================
  Files           295      295              
  Lines         43243    43234       -9     
  Branches        285      285              
============================================
+ Hits          30122    30123       +1     
+ Misses        11646    11636      -10     
  Partials       1475     1475              
Files Changed Coverage Δ
internal/pkg/cli/init.go 20.37% <0.00%> (+0.47%) ⬆️
internal/pkg/cli/env_init.go 65.18% <25.00%> (+0.04%) ⬆️

@mergify mergify bot merged commit b86cf91 into aws:mainline Jul 27, 2023
12 checks passed
Sprint 🏃‍♀️ automation moved this from In review to Pending release Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants