chore: default the writer of docker build to Stderr incase of single image
#5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍕 Here are the new binary sizes!
|
Codecov Report
@@ Coverage Diff @@
## mainline #5148 +/- ##
============================================
- Coverage 69.51% 69.48% -0.04%
============================================
Files 295 295
Lines 43333 43387 +54
Branches 285 285
============================================
+ Hits 30124 30148 +24
- Misses 11740 11767 +27
- Partials 1469 1472 +3
|
dannyrandall
added
the
do-not-merge
KollaAdithya
removed
the
do-not-merge
huanjani
reviewed
Aug 3, 2023
|
Could we add a unit test for multiple images? |
|
I think we already had a test case for this scenario of multiple images over here |
iamhopaul123
reviewed
Aug 7, 2023
internal/pkg/cli/deploy/workload.go
Outdated
| @@ -401,6 +401,7 @@ func (d *workloadDeployer) uploadContainerImages(out *UploadArtifactsOutput) err | |||
| if len(buildArgsPerContainer) == 0 { | |||
| return nil | |||
| } | |||
| isMultipleContainerImages := len(buildArgsPerContainer) > 1 | |||
There was a problem hiding this comment.
Does it make more sense for us to call a separate function if isMultipleContainerImages is true (after repository.Login())? The reason is we probably don't need the parallel part at all for single build case and it'll be easier to read/maintain
KollaAdithya
added
the
do-not-merge
KollaAdithya
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #5124, #5067
This PR will remove the rolling display when there is only one image to build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.