Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): initialize versioning for jobs #5183

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

huanjani
Copy link
Contributor

@huanjani huanjani commented Aug 10, 2023

A customer reported a discrepancy between copilot deploy and copilot job deploy for deploying a job. Template versioning wasn't being initialized in the former, so the detected version was empty.

https://app.gitter.im/#/room/#aws_copilot-cli:gitter.im/$Bq0Q0Yn3V_41DowpRV3dCcV-6mTXsYAYCbu1dDj0qR0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@huanjani huanjani requested a review from a team as a code owner August 10, 2023 21:04
@huanjani huanjani requested review from dannyrandall and removed request for a team August 10, 2023 21:04
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51532 51488 +0.09
macOS (arm) 51732 51680 +0.10
linux (amd) 45364 45324 +0.09
linux (arm) 43648 43588 +0.14
windows (amd) 42180 42144 +0.09

Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mergify mergify bot merged commit 34fa288 into aws:mainline Aug 10, 2023
12 checks passed
Sprint 🏃‍♀️ automation moved this from In review to Pending release Aug 10, 2023
@huanjani huanjani deleted the versioning branch August 10, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants