Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade lambda and codebuild default runtime from nodejs16.x to nodejs18.x #5429

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: upgrade lambda and codebuild default runtime from nodejs16.x to nodejs18.x #5429

merged 1 commit into from
Oct 31, 2023

Conversation

iamhopaul123
Copy link
Contributor

Resolves #5422

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested review from hkford and a team as code owners October 30, 2023 21:57
@iamhopaul123 iamhopaul123 requested review from Lou1415926 and removed request for a team October 30, 2023 21:57
@github-actions
Copy link

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 52208 51976 +0.45
macOS (arm) 53064 52812 +0.48
linux (amd) 45928 45716 +0.46
linux (arm) 45252 45060 +0.43
windows (amd) 43368 43168 +0.46

@mergify mergify bot merged commit c30e076 into aws:mainline Oct 31, 2023
12 checks passed
iamhopaul123 added a commit that referenced this pull request Oct 31, 2023
@iamhopaul123
Revert "chore: upgrade lambda and codebuild default runtime from node…
3ab680c 
…js16.x to nodejs18.x (#5429)"

This reverts commit c30e076.
@iamhopaul123 iamhopaul123 mentioned this pull request Oct 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@iamhopaul123
chore: Revert "chore: upgrade lambda and codebuild default runtime fr…
9c9cf3b 
…om nodejs16.x to nodejs18.x" (#5432)

Reverts #5429 because we can't use SDK v2 in our custom resource code. Adopting to SDK v3 takes more effort. Reverting the PR for now to unblock the other PRs.
@KollaAdithya KollaAdithya mentioned this pull request Jan 2, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
@KollaAdithya
chore: upgrade sdk js to V3 and lambda to runtime 20.x (#5583)
50ed8b5 
Resolves #5422
On top of this PR #5429 upgraded sdk js to V3


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyrandall dannyrandall dannyrandall approved these changes

@Lou1415926 Lou1415926 Lou1415926 approved these changes

@hkford hkford Awaiting requested review from hkford hkford is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js 16 is now 'End of Life'
3 participants
@iamhopaul123 @dannyrandall @Lou1415926