chore: upgrade sdk js to V3 and lambda to runtime 20.x #5583
Conversation
|
🍕 Here are the new binary sizes!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5583 +/- ##
============================================
- Coverage 70.03% 70.02% -0.01%
============================================
Files 302 302
Lines 46498 46533 +35
Branches 301 299 -2
============================================
+ Hits 32563 32583 +20
- Misses 12350 12365 +15
Partials 1585 1585 ☔ View full report in Codecov by Sentry. |
| @@ -17,7 +17,7 @@ List of all available properties for a Copilot pipeline manifest. To learn more | |||
| # connection_name: a-connection | |||
|
|
|||
| build: | |||
| image: aws/codebuild/amazonlinux2-x86_64-standard:4.0 | |||
| image: aws/codebuild/amazonlinux2-x86_64-standard:5.0 | |||
There was a problem hiding this comment.
Do you know if the following scenarios will break for pipeline users
- They don't update the pipeline by running
copilot pipeline deployagain so the codebuild won't be updated. However, they updated the buildspec to use the latest Copilot. - They updated the pipeline and the codebuild was upgrade to
amazonlinux2-x86_64-standard:5.0. However, they forgot to update the buildspec file.
If so, we might want to make sure they are fully aware of the reason why this happen and what to do to get it around (by looking at the codebuild log).
There was a problem hiding this comment.
I did not test these scenarios. I will deploy a pipeline to test these
There was a problem hiding this comment.
I tested both the scenarios, surprisingly it did not error out.
There was a problem hiding this comment.
Cool! That's even better. It seems like we don't depend on the current env nodejs when they use Copilot.
There was a problem hiding this comment.
I have only default buildspec that copilot generates other than changing it to latest version.
what if the customer have some commands like make test where they are running some unit tests for their application based on nodejs environment.
Do we need consider this scenario?
There was a problem hiding this comment.
Hmm it should be good i think, as they should be aware of their dependency on nodejs version. Whereas if the default scenario breaks, they probably don't know why nodejs version would even matter.
KollaAdithya
force-pushed
the
upgrade/sdk-js/v3
branch
from
0552c4f
to
b6496a1
Compare
Resolves #5422
On top of this PR #5429 upgraded sdk js to V3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.