Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ja): periodic update for v1.31 and v1.32 #5510

Merged
merged 4 commits into from Dec 1, 2023

Conversation

otty246
Copy link
Contributor

@otty246 otty246 commented Nov 30, 2023

docs(ja): periodic update for v1.31 and v1.32 (changes from 3a73f6e to 4259e64)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5ffae6) 70.04% compared to head (259fce9) 70.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #5510   +/-   ##
=========================================
  Coverage     70.04%   70.04%           
=========================================
  Files           302      302           
  Lines         46064    46064           
  Branches        309      309           
=========================================
+ Hits          32264    32265    +1     
+ Misses        12235    12234    -1     
  Partials       1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 30, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56640 55192 🥺 +2.62
macOS (arm) 57644 56144 🥺 +2.67
linux (amd) 49660 48440 🥺 +2.52
linux (arm) 48896 47748 🥺 +2.40
windows (amd) 46792 45672 🥺 +2.45

Copy link
Collaborator

@hkford hkford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for localizing both Copilot v1.31 and v1.32. I left some comments.

site/content/blogs/release-v131.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v131.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v131.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v131.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v131.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v131.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v132.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v132.ja.md Outdated Show resolved Hide resolved
site/content/blogs/release-v132.ja.md Outdated Show resolved Hide resolved
site/content/docs/concepts/services.ja.md Outdated Show resolved Hide resolved
@otty246
Copy link
Contributor Author

otty246 commented Dec 1, 2023

@hkford thank you very much! I've updated that responds all of your comments, so could you review again?

Copy link
Collaborator

@hkford hkford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick response @otty246 ! I approved your PR.

Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🙇

@mergify mergify bot merged commit f847fef into aws:mainline Dec 1, 2023
12 checks passed
Sprint 🏃‍♀️ automation moved this from In review to Pending release Dec 1, 2023
hkford pushed a commit that referenced this pull request Dec 1, 2023
docs(ja): periodic update for v1.31 and v1.32 (changes from 3a73f6e to 4259e64)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants