Fix: Domainless option in opensource mode #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The domainless option in ecs mode was overwriting the previously existing opensource mode
The domainless option in ecs mode was overwriting the previously existing opensource mode Testing: root@EC2AMAZ-ByoJfX:~/credentials-fetcher/build# ./credentials-fetcherd --aws_sm_secret_name aws/directoryservices/d-xxxxxxxxx:/gmsa & root@EC2AMAZ-ByoJfX:~/credentials-fetcher/build# ./api/tests/gmsa_test_client --create_kerberos_tickets_non_domain_joined "user1" "xxx" "CONTOSO.COM" krb tickets will get created created ticket file /var/credentials-fetcher/krbdir/1377bbf83874d1a8b7bb/WebApp01 created ticket file /var/credentials-fetcher/krbdir/1377bbf83874d1a8b7bb/WebApp03 Client received output for add kerberos lease non domain joined: 1377bbf83874d1a8b7bb
as14692
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #129
Description of changes:
The domainless option in ecs mode was overwriting the previously existing opensource mode
Testing done:
Testing:
$ ./credentials-fetcherd --aws_sm_secret_name aws/directoryservices/d-xxxxxxxxx:/gmsa &
$ ./api/tests/gmsa_test_client --create_kerberos_tickets_non_domain_joined "user1" "xxx" "CONTOSO.COM"
krb tickets will get created
created ticket file /var/credentials-fetcher/krbdir/1377bbf83874d1a8b7bb/WebApp01
created ticket file /var/credentials-fetcher/krbdir/1377bbf83874d1a8b7bb/WebApp03
Client received output for add kerberos lease non domain joined: 1377bbf83874d1a8b7bb
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.