Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Domainless option in opensource mode #131

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Fix: Domainless option in opensource mode #131

merged 3 commits into from
Jul 15, 2024

Commits on Jul 12, 2024

  1. Fix: Domainless option in opensource mode 

    The domainless option in ecs mode was overwriting the previously existing opensource mode
    @smhmhmd
    smhmhmd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3201de6 View commit details
    Browse the repository at this point in the history

  2. Fix: Domainless option in opensource mode 

    The domainless option in ecs mode was overwriting the previously existing opensource mode

Testing:
  root@EC2AMAZ-ByoJfX:~/credentials-fetcher/build# ./credentials-fetcherd  --aws_sm_secret_name  aws/directoryservices/d-xxxxxxxxx:/gmsa &
  root@EC2AMAZ-ByoJfX:~/credentials-fetcher/build# ./api/tests/gmsa_test_client --create_kerberos_tickets_non_domain_joined "user1" "xxx" "CONTOSO.COM"
  krb tickets will get created
created ticket file /var/credentials-fetcher/krbdir/1377bbf83874d1a8b7bb/WebApp01
created ticket file /var/credentials-fetcher/krbdir/1377bbf83874d1a8b7bb/WebApp03
Client received output for add kerberos lease non domain joined: 1377bbf83874d1a8b7bb
    @smhmhmd
    smhmhmd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    88705c8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'mainline' of https://github.com/smhmhmd/credentials-fet… 

    …cher into mainline
    @smhmhmd
    smhmhmd committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a7b8814 View commit details
    Browse the repository at this point in the history