Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CAPI Backup on workload cluster during upgrade #7364

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Jan 24, 2024

Issue #, if available:
#6797

Description of changes:
Run CAPI Backup on workload cluster during upgrade.
With this change,

  • Management cluster's backup would be under management-cluster-name/management-cluster-name-backup-current-time directory.
  • Workload cluster's backup would be under management-cluster-name/workload-cluster-name-backup-current-time directory.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (39bfc02) 71.76% compared to head (9190ed7) 71.76%.
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/workflows/workload/post_cluster_upgrade.go 66.66% 4 Missing and 1 partial ⚠️
pkg/workflows/workload/writeclusterconfig.go 50.00% 3 Missing ⚠️
pkg/workflows/workload/pre_cluster_upgrade.go 88.23% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7364   +/-   ##
=======================================
  Coverage   71.76%   71.76%           
=======================================
  Files         560      562    +2     
  Lines       43514    43553   +39     
=======================================
+ Hits        31226    31255   +29     
- Misses      10565    10574    +9     
- Partials     1723     1724    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panktishah26 panktishah26 merged commit 0770793 into aws:main Jan 25, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants