Add protobuf to csharp client #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, please .gitignore the auto-generated files. we don't need to hold them in git. |
|
and please comment your classes. Why do we need the split between base and direct clients? |
This is easy when developing the client to perform improvements without braking the interface for the customers |
I will remove them. but I think it is more convenience to see the generated code when investigating issues |
Yury-Fridlyand
added a commit
that referenced
this pull request
May 10, 2024
* Update transaction handling and IT (#160) * Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
avifenesh
pushed a commit
that referenced
this pull request
May 14, 2024
* Update transaction handling and IT (#160) * Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.