Java: Update transaction handling and IT #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix test and command manager. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * SPOTLESS I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Copy from #165. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Revert some refactoring. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Revert timeout change. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * SPOTLESS I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Group commands in transaction IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Refresh Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Test fixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix for redis 6. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…ansaction_IT Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
alex-arzola-imp,
barshaul,
acarbonetto,
shohamazon and
SanHalacogluImproving
…ansaction_IT Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
GumpacG and
tjzhang-BQ
and removed request for
alex-arzola-imp and
SanHalacogluImproving
|
@Yury-Fridlyand any updates? CI is failing |
|
Fixed |
acarbonetto
reviewed
May 2, 2024
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
@shohamazon Can you please review? |
aaron-congo
approved these changes
May 7, 2024
…ansaction_IT Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
CI failure will be fixed by merging amazon-contributing/redis-rs#143 |
acarbonetto
approved these changes
May 8, 2024
shohamazon
reviewed
May 9, 2024
| .pexpire(genericKey1, 42, ExpireOptions.NEW_EXPIRY_GREATER_THAN_CURRENT) | ||
| .pexpireAt(genericKey1, 42, ExpireOptions.HAS_NO_EXPIRY); | ||
| } | ||
| // TODO add BZMPOP from #194 here |
There was a problem hiding this comment.
why? its a sorted set command
There was a problem hiding this comment.
oh, it is copy-paste artifact
be sure to not merge before CI is green :) |
shohamazon
reviewed
May 9, 2024
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
…ansaction_IT Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Elen-Ghulam
approved these changes
May 9, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
avifenesh
pushed a commit
that referenced
this pull request
May 14, 2024
* Update transaction handling and IT (#160) * Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
CommandManagertransaction related methods.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.