Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar hover color #293

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

Description

Removes the background color on the results count text. This makes the background clear which allows the hover color to come through.

Validation

  1. Open search panel to get results
  2. Close search panel
  3. See non-hover result count in search bar
  4. Hover over to see hover state

Normal

CleanShot 2024-04-02 at 16 14 48@2x

Hover

CleanShot 2024-04-02 at 16 14 56@2x

Related Issues

Fixes #291

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm run checks to ensure code compiles and meets standards.
  • I have run pnpm run test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@michaelnchin michaelnchin merged commit 68004ee into aws:main Apr 2, 2024
1 check was pending
@kmcginnes kmcginnes deleted the fix-search-hover branch April 3, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Search input hover color is inconsistent
3 participants