Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gremlin Server 3.7 #411

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented May 20, 2024

Graph Explorer breaks in Gremlin Server 3.7 because the response content type changed from 3.6.

To ensure we always get the content type we expect we set the header:

"Accept": "application/vnd.gremlin-v3.0+json"

This is done on the client and the server.

Validation

  • Test with Gremlin Server 3.6
  • Test with Gremlin Server 3.7
  • Test with Neptune 1.3

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review May 20, 2024 23:45
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.94%. Comparing base (361c4ba) to head (8ae0601).
Report is 20 commits behind head on main.

Files Patch % Lines
...-explorer/src/connector/gremlin/gremlinExplorer.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   13.97%   14.94%   +0.96%     
==========================================
  Files         414      415       +1     
  Lines       30639    30809     +170     
  Branches      878      953      +75     
==========================================
+ Hits         4283     4604     +321     
+ Misses      26026    25878     -148     
+ Partials      330      327       -3     
Flag Coverage Δ
unittests 14.94% <0.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelnchin michaelnchin self-requested a review May 21, 2024 00:33
michaelnchin
michaelnchin previously approved these changes May 21, 2024
vkagamlyk
vkagamlyk previously approved these changes May 21, 2024
@kmcginnes kmcginnes dismissed stale reviews from vkagamlyk and michaelnchin via 0df55bf May 21, 2024 14:19
@kmcginnes kmcginnes merged commit 7826d22 into aws:main May 21, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-gremlin-server-3.7 branch May 21, 2024 14:20
@kmcginnes kmcginnes modified the milestone: Release 1.8.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Support for Gremlin Server 3.7 is broken
3 participants