Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed elementMap identification #174

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Fixed elementMap identification #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51765cc
Fix elementMap node identification
michaelnchin Aug 6, 2021
9bb33de
Changelog update
michaelnchin Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Starting with v1.31.6, this file will contain a record of major features and updates made in each release of graph-notebook.

## Upcoming
- Gremlin visualization bugfixes ([Link to PR](https://github.com/aws/graph-notebook/pull/166))
- Gremlin visualization bugfixes ([PR #1](https://github.com/aws/graph-notebook/pull/166)) ([PR #2](https://github.com/aws/graph-notebook/pull/174))
- Updated the airport data loadable via %seed to the latest version ([Link to PR](https://github.com/aws/graph-notebook/pull/172))
- Added support for Gremlin Profile API parameters ([Link to PR](https://github.com/aws/graph-notebook/pull/171))
- Improved %seed so the progress bar is seen to complete ([Link to PR](https://github.com/aws/graph-notebook/pull/173))
Expand Down
5 changes: 4 additions & 1 deletion src/graph_notebook/network/gremlin/GremlinNetwork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def add_results(self, results):
if T.id in path[i] and T.label in path[i]:
for prop, value in path[i].items():
# T.id and/or T.label could be renamed by a project() step
if prop not in [T.id, T.label] and isinstance(value, str):
if isinstance(value, str) and prop not in [T.id, T.label]:
is_elementmap = True
break
elif isinstance(value, dict):
Expand All @@ -261,6 +261,9 @@ def add_results(self, results):
break
elif isinstance(value, list):
break
elif not isinstance(value, (str, list, dict)):
is_elementmap = True
break
if is_elementmap:
self.insert_elementmap(path[i])
else:
Expand Down