-
Notifications
You must be signed in to change notification settings - Fork 244
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Actually upgrade the `node` engine support to 10.x tree, as has been declared in the `package.json` files for a month now. Additionally, standardized the `compilerOptions` in the `tsconfig.json` files that are *not* generated by `jsii`, in order to use `ES2018` standard library, enable `strict` mode (this includes `strictPropertyInitialization`, which was not enabled previously and required a few code changes in `jsii-pacmak` that were made ad-minima). The library clause of `tsconfig.json` files that are generated by `jsii` has not been changed yet. This means you need to use `node >= 10.x` in order to use `jsii`, but you cannot use it to build code that depend on APIs that are not yet available in `node 8`. This behavior will be updated in a second phase. Related: #794
- Loading branch information
1 parent
0cc1a4c
commit 11cb590
Showing
26 changed files
with
282 additions
and
654 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,19 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ | ||
| "target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "lib": ["es2016", "es2017.object", "es2017.string"], /* Specify library files to be included in the compilation: */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "lib": ["es2018"], /* Specify library files to be included in the compilation: */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ | ||
| "strictNullChecks": true, /* Enable strict null checks. */ | ||
| "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */ | ||
| "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ | ||
| "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
| "inlineSourceMap": true, | ||
| "inlineSources": true, | ||
| "composite": true | ||
| "resolveJsonModule": true, /* Include modules imported with .json extension. */ | ||
| "composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */ | ||
| "incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */ | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,19 @@ | ||
| { | ||
| "compilerOptions": { | ||
| /* Basic Options */ | ||
| "target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "lib": ["es2016", "es2017.object", "es2017.string"], /* Specify library files to be included in the compilation: */ | ||
| // "allowJs": true, /* Allow javascript files to be compiled. */ | ||
| // "checkJs": true, /* Report errors in .js files. */ | ||
| // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| // "sourceMap": true, /* Generates corresponding '.map' file. */ | ||
| // "outFile": "./", /* Concatenate and emit output to single file. */ | ||
| // "outDir": "./", /* Redirect output structure to the directory. */ | ||
| // "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ | ||
| // "removeComments": true, /* Do not emit comments to output. */ | ||
| // "noEmit": true, /* Do not emit outputs. */ | ||
| // "importHelpers": true, /* Import emit helpers from 'tslib'. */ | ||
| // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ | ||
| // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ | ||
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ | ||
| "strictNullChecks": true, /* Enable strict null checks. */ | ||
| "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */ | ||
| "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
| "strictPropertyInitialization": false, /* DO NOT Raise error on class attribute not initialized by constructor. */ | ||
|
|
||
| /* Additional Checks */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
|
|
||
| /* Module Resolution Options */ | ||
| // "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | ||
| // "baseUrl": "./", /* Base directory to resolve non-absolute module names. */ | ||
| // "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ | ||
| // "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */ | ||
| // "typeRoots": [], /* List of folders to include type definitions from. */ | ||
| // "types": [], /* Type declaration files to be included in compilation. */ | ||
| // "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ | ||
|
|
||
| /* Source Map Options */ | ||
| // "sourceRoot": "./", /* Specify the location where debugger should locate TypeScript files instead of source locations. */ | ||
| // "mapRoot": "./", /* Specify the location where debugger should locate map files instead of generated locations. */ | ||
| // "inlineSourceMap": false, /* Emit a single file with source maps instead of having a separate file. */ | ||
| // "inlineSources": false, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */ | ||
|
|
||
| /* Experimental Options */ | ||
| "experimentalDecorators": true /* Enables experimental support for ES7 decorators. */ | ||
| // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ | ||
| "target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "lib": ["es2018"], /* Specify library files to be included in the compilation: */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ | ||
| "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
| "resolveJsonModule": true, /* Include modules imported with .json extension. */ | ||
| "composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */ | ||
| "incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */ | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,54 +1,19 @@ | ||
| { | ||
| "compilerOptions": { | ||
| /* Basic Options */ | ||
| "target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "lib": ["es2016", "es2017.object", "es2017.string"], /* Specify library files to be included in the compilation: */ | ||
| // "allowJs": true, /* Allow javascript files to be compiled. */ | ||
| // "checkJs": true, /* Report errors in .js files. */ | ||
| // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| // "sourceMap": true, /* Generates corresponding '.map' file. */ | ||
| // "outFile": "./", /* Concatenate and emit output to single file. */ | ||
| // "outDir": "./", /* Redirect output structure to the directory. */ | ||
| // "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ | ||
| // "removeComments": true, /* Do not emit comments to output. */ | ||
| // "noEmit": true, /* Do not emit outputs. */ | ||
| // "importHelpers": true, /* Import emit helpers from 'tslib'. */ | ||
| // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ | ||
| // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ | ||
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ | ||
| "strictNullChecks": true, /* Enable strict null checks. */ | ||
| "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */ | ||
| "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
| "strictPropertyInitialization": false, /* DO NOT Raise error on class attribute not initialized by constructor. */ | ||
|
|
||
| /* Additional Checks */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
|
|
||
| /* Module Resolution Options */ | ||
| // "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | ||
| // "baseUrl": "./", /* Base directory to resolve non-absolute module names. */ | ||
| // "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ | ||
| // "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */ | ||
| // "typeRoots": [], /* List of folders to include type definitions from. */ | ||
| // "types": [], /* Type declaration files to be included in compilation. */ | ||
| // "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ | ||
|
|
||
| /* Source Map Options */ | ||
| // "sourceRoot": "./", /* Specify the location where debugger should locate TypeScript files instead of source locations. */ | ||
| // "mapRoot": "./", /* Specify the location where debugger should locate map files instead of generated locations. */ | ||
| // "inlineSourceMap": false, /* Emit a single file with source maps instead of having a separate file. */ | ||
| // "inlineSources": false, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */ | ||
|
|
||
| /* Experimental Options */ | ||
| "experimentalDecorators": true /* Enables experimental support for ES7 decorators. */ | ||
| // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ | ||
| "target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "lib": ["es2018"], /* Specify library files to be included in the compilation: */ | ||
| "strict": true, /* Enable all strict type-checking options. */ | ||
| "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ | ||
| "declaration": true, /* Generates corresponding '.d.ts' file. */ | ||
| "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ | ||
| "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file. */ | ||
| "noUnusedLocals": true, /* Report errors on unused locals. */ | ||
| "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
| "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ | ||
| "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
| "resolveJsonModule": true, /* Include modules imported with .json extension. */ | ||
| "composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */ | ||
| "incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */ | ||
| } | ||
| } |
Oops, something went wrong.