-
Notifications
You must be signed in to change notification settings - Fork 244
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(rosetta):
didCompile
evaluates to true when compilation not att…
…empted (#3149) When `rosetta:extract` is run, the property `didCompile` evalutes to `true` even when compilation was not attempted. This causes lots of confusion. The correct way to handle this is to return `undefined` when compilation is not attempted. Then, (I assume) `didCompile` will not show up in the tablet file at all when compilation is not asked for (via `--compile` or `strict`. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
- Loading branch information
Showing
2 changed files
with
40 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters