Skip to content

Commit

Permalink
fix(rosetta): use --compile flag by default (#3218)
Browse files Browse the repository at this point in the history
The way we are trending, there is no good reason anymore to NOT compile
your examples. We have good support for parallelism and caching now,
so the argument that it takes too much time to do the additional
analysis no longer really holds.

Also, why should people have to remember to pass this flag for default
that should arguably be the default?

Make it the default.



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
  • Loading branch information
rix0rrr committed Nov 30, 2021
1 parent d379626 commit 9df7950
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/jsii-rosetta/bin/jsii-rosetta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ function main() {
.option('compile', {
alias: 'c',
type: 'boolean',
describe: 'Try compiling',
default: false,
describe: 'Try compiling (on by default, use --no-compile to switch off)',
default: true,
})
.option('directory', {
alias: 'd',
Expand Down

0 comments on commit 9df7950

Please sign in to comment.