fix(python): incorrect dependency on jsii (#1582)

The Python runtime dependency of generated Python code was incorrectly pinning on the minor, instead of allowing the necessary semver range. Changed the dependency statement from `~=<version>` to the correctly translated caret range. Fixes #1573
aws · Apr 20, 2020 · eed53ed · eed53ed
1 parent fac53d9
commit eed53ed
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/packages/jsii-pacmak/lib/targets/python.ts b/packages/jsii-pacmak/lib/targets/python.ts
@@ -1212,7 +1212,7 @@ class Package {
       packages: modules.map(m => m.pythonName),
       package_data: packageData,
       python_requires: '>=3.6',
-      install_requires: [`jsii~=${jsiiVersionSimple}`, 'publication>=0.0.3'].concat(dependencies),
+      install_requires: [`jsii${toPythonVersionRange(`^${jsiiVersionSimple}`)}`, 'publication>=0.0.3'].concat(dependencies),
       classifiers: [
         'Intended Audience :: Developers',
         'Operating System :: OS Independent',

diff --git a/packages/jsii-pacmak/test/expected.jsii-calc-base-of-base/python/setup.py b/packages/jsii-pacmak/test/expected.jsii-calc-base-of-base/python/setup.py
@@ -30,7 +30,7 @@
     },
     "python_requires": ">=3.6",
     "install_requires": [
-        "jsii~=1.1.0",
+        "jsii>=1.1.0, <2.0.0",
         "publication>=0.0.3"
     ],
     "classifiers": [

diff --git a/packages/jsii-pacmak/test/expected.jsii-calc-base/python/setup.py b/packages/jsii-pacmak/test/expected.jsii-calc-base/python/setup.py
@@ -30,7 +30,7 @@
     },
     "python_requires": ">=3.6",
     "install_requires": [
-        "jsii~=1.1.0",
+        "jsii>=1.1.0, <2.0.0",
         "publication>=0.0.3",
         "scope.jsii-calc-base-of-base>=1.1.0, <2.0.0"
     ],

diff --git a/packages/jsii-pacmak/test/expected.jsii-calc-lib/python/setup.py b/packages/jsii-pacmak/test/expected.jsii-calc-lib/python/setup.py
@@ -30,7 +30,7 @@
     },
     "python_requires": ">=3.6",
     "install_requires": [
-        "jsii~=1.1.0",
+        "jsii>=1.1.0, <2.0.0",
         "publication>=0.0.3",
         "scope.jsii-calc-base>=1.1.0, <2.0.0"
     ],

diff --git a/packages/jsii-pacmak/test/expected.jsii-calc/python/setup.py b/packages/jsii-pacmak/test/expected.jsii-calc/python/setup.py
@@ -30,7 +30,7 @@
     },
     "python_requires": ">=3.6",
     "install_requires": [
-        "jsii~=1.1.0",
+        "jsii>=1.1.0, <2.0.0",
         "publication>=0.0.3",
         "scope.jsii-calc-base>=1.1.0, <2.0.0",
         "scope.jsii-calc-base-of-base>=1.1.0, <2.0.0",