Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): README.md filename is case sensitive #1871

Merged
merged 8 commits into from
Aug 12, 2020
Merged

Conversation

RomainMuller
Copy link
Contributor

The README.md file was processed in a case sensitive manner, but it
does not really matter what casing it uses. Changed the flow to look for
the file in a case-insensitive manner instead.

Fixes #1862


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The `README.md` file was processed in a case sensitive manner, but it
does not really matter what casing it uses. Changed the flow to look for
the file in a case-insensitive manner instead.

Fixes #1862
@RomainMuller RomainMuller requested a review from a team August 11, 2020 11:49
@RomainMuller RomainMuller self-assigned this Aug 11, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 11, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 12, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Merging (with squash)...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 7728199
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e375647 into master Aug 12, 2020
@mergify mergify bot deleted the rmuller/readme-casing branch August 12, 2020 18:04
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme.md Filename Case Sensitive for Python
3 participants