Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): missing setter for R/W interface properties #2731

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

RomainMuller
Copy link
Contributor

Adding the missing code generation for interface properties that are
writable. Previously, only the reader was generated.

Fixes #2665


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adding the missing code generation for interface properties that are
writable. Previously, only the reader was generated.

Fixes #2665
@RomainMuller RomainMuller added bug This issue is a bug. language/go Regarding GoLang bindings effort/small Small work item – less than a day of effort module/pacmak Issues affecting the `jsii-pacmak` module labels Mar 22, 2021
@RomainMuller RomainMuller requested a review from a team March 22, 2021 12:53
@RomainMuller RomainMuller self-assigned this Mar 22, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Merging (with squash)...

@mergify mergify bot merged commit 74d0d99 into main Mar 23, 2021
@mergify mergify bot deleted the rmuller/missing-setters branch March 23, 2021 00:30
@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort language/go Regarding GoLang bindings module/pacmak Issues affecting the `jsii-pacmak` module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go: missing setters for read-write properties
2 participants