Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): dereference values returned from Kernel.ainvoke #3847

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

jpantzlaff
Copy link
Contributor

Currently, calling an async method via the Python runtime results in an ObjRef being returned, rather than an instance of the desired object.

Applying the @_dereferenced decorator to Kernel.ainvoke, similar to what is already done for sinvoke, fixes the problem.

Fixes #3620


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2022

Merging (with squash)...

@mergify mergify bot merged commit 5643c50 into aws:main Nov 23, 2022
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 23, 2022
@jpantzlaff jpantzlaff deleted the python-dereference-ainvoke branch November 23, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: sync vs async return different objects but same type-hint
2 participants